Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use eigen3 header instead of tf third_party/eigen3 #45701

Merged
merged 1 commit into from
Aug 19, 2024
Merged

use eigen3 header instead of tf third_party/eigen3 #45701

merged 1 commit into from
Aug 19, 2024

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Aug 14, 2024 •
edited
Loading

This change allows to pick up eigen3 header from our distribution of eigen instead of tensorflow/third_party/eigen3. This is needed for TF 2.16 but should work for old versions of TF too. This should be test with cms-sw/cmsdist#9360 and should be merged only after cms-sw/cmsdist#9360 is in IB.

[a] cms-sw/cmsdist#9241 (comment)

>> Compiling  src/PhysicsTools/TensorFlowAOT/src/Wrapper.cc
In file included from src/PhysicsTools/TensorFlowAOT/src/Wrapper.cc:10:
src/PhysicsTools/TensorFlowAOT/interface/Wrapper.h:15:10: fatal error: third_party/eigen3/unsupported/Eigen/CXX11/Tensor: No such file or directory
   15 | #include "third_party/eigen3/unsupported/Eigen/CXX11/Tensor"

@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Aug 14, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 14, 2024 •
edited
Loading

cms-bot internal usage

@smuzaffar smuzaffar mentioned this pull request Aug 14, 2024
Merged
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45701/41314

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • PhysicsTools/TensorFlowAOT (ml)

@cmsbuild, @valsdav, @y19y19 can you please review it and eventually sign? Thanks.
@makortel, @riga this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmsdist#9360

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a6a374/40918/summary.html
COMMIT: 2827597
CMSSW: CMSSW_14_1_X_2024-08-14-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45701/40918/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a6a374/40918/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a6a374/40918/git-merge-result

Comparison Summary

Summary:

  • You potentially added 18 lines to the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3422510
  • DQMHistoTests: Total failures: 18
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3422472
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 196 log files, 165 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

@cms-sw/ml-l2 , can you please review this?

@iarspider iarspider mentioned this pull request Aug 15, 2024
Merged
@smuzaffar
Copy link
Contributor Author

@valsdav, @y19y19 can you please review this?

@valsdav
Copy link
Contributor

valsdav commented Aug 19, 2024

+1
(sorry for the slow response, I was away)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1
Required external was already merged some days ago

@cmsbuild cmsbuild merged commit 0964abb into cms-sw:master Aug 19, 2024
11 checks passed
This was referenced Aug 19, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved fully-signed ml-approved orp-approved requires-external tests-approved
Projects
None yet
Milestone
CMSSW_14_1_X
Development

Successfully merging this pull request may close these issues.
4 participants
@smuzaffar @cmsbuild @valsdav @mandrenguyen